warn patch maintainer to remove patch #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlawler
force-pushed
the
split-patches
branch
from
22f9fea
to
239bc14
Compare
|
|
bridiver
reviewed
Jan 9, 2018
lib/updatePatches.js
Outdated
| console.log('updatePatches writing files to: ' + patchDir) | ||
|
|
||
| // grab Modified (and later Deleted) files but not Created (since we copy those) | ||
| const modifiedDiffArgs = ['diff', '--diff-filter=M', '--name-only', '--ignore-space-at-eol'] | ||
| let modifiedDiff = util.run('git', modifiedDiffArgs, runOptions) | ||
| let moddedFileList = modifiedDiff.stdout.toString().split('\n').filter(s => s.length > 0) | ||
| let modifiedDiff = util.run('git', modifiedDiffArgs, runOptionsChrome) |
There was a problem hiding this comment.
can we split some of this out into separate methods in a follow-up?
Fix #49 rm cruft patches in addition to notifying
bbondy
approved these changes
Jul 6, 2018
|
Rebased, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brave/brave#49